Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github stale workflow: rephrase and bump close time #4788

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Jan 4, 2020

Rephrase the stale message to be friendlier and bump the closing time to
365 days. The docs of the stale workflow do not indicate whether we can
not close, so a limit of 365 days seems fair.

Signed-off-by: Valentin Rothberg [email protected]

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2020
@vrothberg
Copy link
Member Author

@rhatdan @onlyjob PTAL

@rhatdan
Copy link
Member

rhatdan commented Jan 4, 2020

LGTM

stale-issue-message: 'This issue had no activity for 30 days. In the absence of activity or the "do-not-close" label, the issue will be automatically closed within 7 days.'
stale-pr-message: 'This pull request had no activity for 30 days. In the absence of activity or the "do-not-close" label, the pull request will be automatically closed within 7 days.'
stale-issue-message: 'A friendly reminder that this issue had no activity for 30 days.'
stale-pr-message: 'A friendly reminder that this PR had no activity for 30 days.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not closing these after 7 days now? If so, I think that should still be noted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we are closing after one year. The intention is to not close at all but the docs of the stale workflow do not indicate whether we can not close, so a limit of 365 days seems fair.

.github/workflows/stale.yml Outdated Show resolved Hide resolved
Rephrase the stale message to be friendlier and bump the closing time to
365 days.  The docs of the stale workflow do not indicate whether we can
not close, so a limit of 365 days seems fair.

Signed-off-by: Valentin Rothberg <[email protected]>
@vrothberg
Copy link
Member Author

@baude @mheon PTAL

@mheon
Copy link
Member

mheon commented Jan 7, 2020

I'm in favor. We've dealt with the initial lot of issues; it's still valuable for reminding us that issues need to be closed, but most of the time it's one more thing I need to whack with do-not-close

@TomSweeneyRedHat
Copy link
Member

Fighting build issues, otherwise LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2020
@openshift-merge-robot openshift-merge-robot merged commit bd3d8f4 into containers:master Jan 7, 2020
@vrothberg vrothberg deleted the stale branch January 8, 2020 07:51
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants